Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: implement eip-7702 set code tx #30078

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

all: implement eip-7702 set code tx #30078

wants to merge 45 commits into from

Conversation

lightclient
Copy link
Member

@lightclient lightclient commented Jun 26, 2024 •
edited
Loading

Spec: EIP-7702: Set EOA account code

Add a new transaction type that adds a list of [chain_id, address, nonce, y_parity, r, s] authorization tuples. For each tuple, write a delegation designator (0xef0100 ++ address) to the signing account’s code. All code reading operations must load the code pointed to by the designator.

@lightclient lightclient force-pushed the eip-7702 branch 2 times, most recently from bc22287 to 95524bb Compare June 26, 2024 23:31
@rjl493456442
Copy link
Member

Should we propose another EIP to revamp EIP158? Otherwise, as we discussed previously, the leftover storage of an "empty" EOA could be cleared at the end of block.

@lightclient
Copy link
Member Author

@rjl493456442 I think the proposal which will get accepted for devnet-2 and on will avoid the 158 problem, so it's probably okay to just let it play out. ethereum/EIPs#8677

@lightclient lightclient force-pushed the eip-7702 branch 5 times, most recently from ff4dba2 to 955384a Compare July 18, 2024 17:47
@Brechtpd Brechtpd mentioned this pull request Jul 19, 2024
Closed
1 task
@lightclient lightclient force-pushed the eip-7702 branch 2 times, most recently from e3834ac to 20ea148 Compare August 21, 2024 22:41
@lightclient lightclient force-pushed the eip-7702 branch 4 times, most recently from 94389ba to 8578fb7 Compare September 9, 2024 20:24
buddh0
buddh0 reviewed Sep 18, 2024
View reviewed changes
core/state_transition.go Outdated Show resolved Hide resolved
buddh0
buddh0 reviewed Sep 18, 2024
View reviewed changes
core/state_transition.go Outdated Show resolved Hide resolved
buddh0
buddh0 reviewed Sep 19, 2024
View reviewed changes
core/vm/operations_acl.go Outdated Show resolved Hide resolved
buddh0
buddh0 reviewed Sep 19, 2024
View reviewed changes
core/vm/operations_acl.go Outdated Show resolved Hide resolved
@NathanBSC NathanBSC mentioned this pull request Sep 27, 2024
Closed
@buddh0 buddh0 mentioned this pull request Sep 27, 2024
Closed
@ethereum ethereum deleted a comment from Kya123iu Oct 1, 2024
@octavio12345300 octavio12345300 mentioned this pull request Oct 3, 2024
Closed
Kya123iu

This comment was marked as spam.

Sign in to view

@buddh0

This comment was marked as resolved.

Sign in to view
fjl and others added 21 commits December 12, 2024 08:59
@fjl @lightclient
cmd/evm: update testdata
a0274e0
@fjl @lightclient
graphql: add support for fee parameters of SetCodeTx
33888a9
@fjl @lightclient
core: improve checks for 7702
e7c0f80 
- prevent SetCodeTx in create mode (similar to blob tx)
- move check for non-empty auth list to preCheck
@fjl @lightclient
core: add comment about 7702 state transition error
bd36423
@holiman @lightclient
core/state: fix hooks to account for setcode on non-empty code
3764d42
@holiman @lightclient
core/state: fix journal to account for setcode over non-empty code
5fccdfb
@fjl @lightclient
core: reformat comment
ace3a3f
@fjl @lightclient
core: clarify delegation deletion flow
1110fc5
@fjl @lightclient
core: more comment
9b94402
@lightclient
core: lift convenience warming of tx destination from per auth to pos…
9ee0d10 
…t application of all authorizations
@lightclient
core: refactor non-create processing flow
f4b5798
@lightclient
internal/ethapi: removed commented out code from test
eda288c
@lightclient
core/vm: direct check code hash during creation instead of resolving
0a129da
@lightclient
tests: use big int for stAuthorization because eest needs math.HexOrD…
6505e50 
…ecimal256 decoding
@lightclient
core: rm extra whitespace
46a6482
@lightclient
t8n: do not omit requests when empty
7ecda7d
@lightclient
core/vm: return delegation designator prefix for code reading ops
fdfc159
@lightclient
core/vm: report gas used warming 7702 delegation targets correctly in…
e98e686 
… tracer
@lightclient
eth/tracers: add support for setcode tx in prestate tracer
aed705b
@holiman @lightclient
core: mod errors + add test
034f897
@lightclient
core: create official prague instruction set, name eof set
857641d
@lightclient
Copy link
Member Author

Rebased to fixed new conflicts. Should be good to go again 👍.

fjl
fjl reviewed Dec 12, 2024
View reviewed changes
core/vm/jump_table.go
func NewPragueEOFInstructionSetForTesting() JumpTable {
return newPragueEOFInstructionSet()
func NewEOFInstructionSetForTesting() JumpTable {
return newEOFInstructionSetForTesting()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have an exported and unexported version of the same function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume because we added the testing function just to do fuzz testing, but didn't want to churn core geth code when we decide to delete it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to remove to consolidate it into the exported function if that's better. Just trying to retain what was there.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exported is named "ForTesting" to signal that nobody should rely on it as official api. Fuzzing yes, and maybe also goevmlab

@rjl493456442
Copy link
Member

Building is failed

@lightclient
Copy link
Member Author

Fixed - PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drortirosh drortirosh drortirosh left review comments

@Voidkai Voidkai Voidkai left review comments

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden left review comments

@lj1nu lj1nu lj1nu left review comments

@fjl fjl fjl left review comments

@buddh0 buddh0 buddh0 left review comments

@rjl493456442 rjl493456442 rjl493456442 left review comments

@sudeepdino008 sudeepdino008 sudeepdino008 left review comments

@zhiqiangxu zhiqiangxu zhiqiangxu left review comments

@holiman holiman holiman requested changes

@namiloh namiloh namiloh left review comments

@marioevz marioevz marioevz left review comments

@Kya123iu Kya123iu Kya123iu requested changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

@s1na s1na Awaiting requested review from s1na s1na is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@fjl fjl

@holiman holiman

@rjl493456442 rjl493456442

@lightclient lightclient

Labels
prague
Projects
None yet
Milestone
1.14.13
Development

Successfully merging this pull request may close these issues.